-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UUIDv7 #4877
base: main
Are you sure you want to change the base?
Add support for UUIDv7 #4877
Conversation
|
CodSpeed Performance ReportMerging #4877 will not alter performanceComparing Summary
|
f5d661e
to
46047f6
Compare
FYI: after this gets an approval, I'll rebase + squash the fixup commits |
@Weakky Gentle ping. Is anything missing in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delayed review and thanks for the quality work @mcuelenaere. Would you mind adding a query-engine test that uses uuid(7)
and:
- create a row with it
- reads it from findMany
- reads it from findUnique
You could add this test in this file: query-engine/connector-test-kit-rs/query-engine-tests/tests/writes/ids/uuid_create_graphql.rs
@mcuelenaere Thanks for the quick review fix. I have run the tests. Would you mind having a look at the failures? |
@Weakky I am able to run the tests for sqlite locally, but they seem to fail in CI for the driver adapters. However, I can't seem to easily run these locally + the output of the CI does not give any indication as to what's going wrong (just that it's failing). Any help would be appreciated. |
This implements prisma/prisma#24079. The change is pretty minimal, widening the support from
@default(uuid())
to@default(uuid(7))
.It leverages the existing
uuid
crate instead of adding a new one (uuid7
).Right now this code is mostly untested (apart from the tests I added toCI runs finepsl
), because I couldn't get the tests running locally. I'd appreciate some guidance in this area.